This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Conversation
This pr simplifies the subsystem jobs interface. Instead of requiring an extra message that is used to signal that a job should be ended, a job now ends when the receiver returns `None`. Besides that it changes the interface to enforce that messages to a job provide a relay parent.
bkchr
added
A0-please_review
coriolinus
reviewed
Nov 30, 2020
Contributor
coriolinus
left a comment
coriolinus
left a comment
There was a problem hiding this comment.
Agree this does what it says. It could go farther: getting rid of ToJob would enable us to remove even more code.
node/subsystem-util/src/lib.rs
Outdated
| /// If the message variant contains its relay parent, return it here | ||
| fn relay_parent(&self) -> Option<Hash>; | ||
| /// Get the relay parent this message is assigned to. | ||
| fn relay_parent(&self) -> Hash; |
Contributor
There was a problem hiding this comment.
This makes ToJobTrait a bit more rigid: it ensures that we'll never write a subsystem using this util which can have jobs not tied to relay parents.
I think this is a reasonable simplification at this point.
We always convert this message to FromJobCommand anyway.
coriolinus
approved these changes
Nov 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr simplifies the subsystem jobs interface. Instead of requiring an
extra message that is used to signal that a job should be ended, a job
now ends when the receiver returns
None. Besides that it changes theinterface to enforce that messages to a job provide a relay parent.